<html>
<head><meta charset="utf-8"><title>review for #73323 · t-compiler · Zulip Chat Archive</title></head>
<h2>Stream: <a href="https://rust-lang.github.io/zulip_archive/stream/131828-t-compiler/index.html">t-compiler</a></h2>
<h3>Topic: <a href="https://rust-lang.github.io/zulip_archive/stream/131828-t-compiler/topic/review.20for.20.2373323.html">review for #73323</a></h3>

<hr>

<base href="https://rust-lang.zulipchat.com">

<head><link href="https://rust-lang.github.io/zulip_archive/style.css" rel="stylesheet"></head>

<a name="201955660"></a>
<h4><a href="https://rust-lang.zulipchat.com#narrow/stream/131828-t-compiler/topic/review%20for%20%2373323/near/201955660" class="zl"><img src="https://rust-lang.github.io/zulip_archive/assets/img/zulip.svg" alt="view this post on Zulip" style="width:20px;height:20px;"></a> davidtwco <a href="https://rust-lang.github.io/zulip_archive/stream/131828-t-compiler/topic/review.20for.20.2373323.html#201955660">(Jun 25 2020 at 11:11)</a>:</h4>
<p>would anyone be able to review <a href="https://github.com/rust-lang/rust/issues/73323">#73323</a>? it's been sitting for a while now.</p>



<a name="201956162"></a>
<h4><a href="https://rust-lang.zulipchat.com#narrow/stream/131828-t-compiler/topic/review%20for%20%2373323/near/201956162" class="zl"><img src="https://rust-lang.github.io/zulip_archive/assets/img/zulip.svg" alt="view this post on Zulip" style="width:20px;height:20px;"></a> Jonas Schievink  [he/him] <a href="https://rust-lang.github.io/zulip_archive/stream/131828-t-compiler/topic/review.20for.20.2373323.html#201956162">(Jun 25 2020 at 11:18)</a>:</h4>
<p>Hmm, should this go through a crater run?</p>



<a name="201956211"></a>
<h4><a href="https://rust-lang.zulipchat.com#narrow/stream/131828-t-compiler/topic/review%20for%20%2373323/near/201956211" class="zl"><img src="https://rust-lang.github.io/zulip_archive/assets/img/zulip.svg" alt="view this post on Zulip" style="width:20px;height:20px;"></a> davidtwco <a href="https://rust-lang.github.io/zulip_archive/stream/131828-t-compiler/topic/review.20for.20.2373323.html#201956211">(Jun 25 2020 at 11:19)</a>:</h4>
<p>probably, I'm not sure what the protocol is there</p>



<a name="201957021"></a>
<h4><a href="https://rust-lang.zulipchat.com#narrow/stream/131828-t-compiler/topic/review%20for%20%2373323/near/201957021" class="zl"><img src="https://rust-lang.github.io/zulip_archive/assets/img/zulip.svg" alt="view this post on Zulip" style="width:20px;height:20px;"></a> lcnr <a href="https://rust-lang.github.io/zulip_archive/stream/131828-t-compiler/topic/review.20for.20.2373323.html#201957021">(Jun 25 2020 at 11:30)</a>:</h4>
<p>The implementation looks good <span aria-label="thumbs up" class="emoji emoji-1f44d" role="img" title="thumbs up">:thumbs_up:</span> I think a crater run would be useful here</p>



<a name="201957043"></a>
<h4><a href="https://rust-lang.zulipchat.com#narrow/stream/131828-t-compiler/topic/review%20for%20%2373323/near/201957043" class="zl"><img src="https://rust-lang.github.io/zulip_archive/assets/img/zulip.svg" alt="view this post on Zulip" style="width:20px;height:20px;"></a> lcnr <a href="https://rust-lang.github.io/zulip_archive/stream/131828-t-compiler/topic/review.20for.20.2373323.html#201957043">(Jun 25 2020 at 11:31)</a>:</h4>
<p>Even if it probably doesn't break anything</p>



<a name="201957390"></a>
<h4><a href="https://rust-lang.zulipchat.com#narrow/stream/131828-t-compiler/topic/review%20for%20%2373323/near/201957390" class="zl"><img src="https://rust-lang.github.io/zulip_archive/assets/img/zulip.svg" alt="view this post on Zulip" style="width:20px;height:20px;"></a> Léo Lanteri Thauvin <a href="https://rust-lang.github.io/zulip_archive/stream/131828-t-compiler/topic/review.20for.20.2373323.html#201957390">(Jun 25 2020 at 11:35)</a>:</h4>
<p>Well, maybe you can request a try build in prevision of a crater run already?</p>



<a name="201957505"></a>
<h4><a href="https://rust-lang.zulipchat.com#narrow/stream/131828-t-compiler/topic/review%20for%20%2373323/near/201957505" class="zl"><img src="https://rust-lang.github.io/zulip_archive/assets/img/zulip.svg" alt="view this post on Zulip" style="width:20px;height:20px;"></a> Jonas Schievink  [he/him] <a href="https://rust-lang.github.io/zulip_archive/stream/131828-t-compiler/topic/review.20for.20.2373323.html#201957505">(Jun 25 2020 at 11:36)</a>:</h4>
<p>done</p>



<hr><p>Last updated: Aug 07 2021 at 22:04 UTC</p>
</html>